feat: support install.nodejs()#2059
Merged
kemingy merged 2 commits intotensorchord:mainfrom Nov 8, 2025
Merged
Conversation
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
kemingy
requested review from
VoVAllen,
gaocegege,
lalawuu and
zwpaper
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds NodeJS programming language support to envd, enabling users to install and use Node.js in their development environments via install.nodejs().
Key Changes:
- Implemented NodeJS installation functionality with configurable version support (default: 25.1.0)
- Added
libatomic1system package dependency required by nodejs - Consolidated separate rust and golang e2e tests into a unified "others" test suite that includes nodejs
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/envd.go | Added libatomic1 to base apt packages for nodejs runtime dependency |
| pkg/lang/ir/v1/system.go | Integrated nodejs case handlers in language compilation logic |
| pkg/lang/ir/v1/nodejs.go | New file implementing nodejs installation from official release binaries |
| pkg/lang/ir/v1/interface.go | Added NodeJS() function to expose nodejs installation in IR API |
| pkg/lang/frontend/starlark/v1/install/install.go | Added starlark binding for install.nodejs() with version parameter |
| pkg/lang/frontend/starlark/v1/install/const.go | Added ruleNodeJS constant for the install rule |
| envd/api/v1/install.py | Added Python API documentation for nodejs() function |
| e2e/language/testdata/rust/build.envd | Removed rust-specific test configuration (consolidated into others) |
| e2e/language/testdata/others/build.envd | New consolidated test configuration for go, rust, and nodejs |
| e2e/language/testdata/golang/build.envd | Removed golang-specific test configuration (consolidated into others) |
| e2e/language/others_test.go | Updated to test go, rust, and nodejs installation in single suite |
Comments suppressed due to low confidence (1)
e2e/language/others_test.go:24
- The test suite description still says "rust" but now tests multiple languages (rust/golang/nodejs). This should be updated to reflect the broader scope, such as "other languages" or "rust/golang/nodejs".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
python/nodejs, we should be able to install most of the code agents with the language package managers.